Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Name typo #656

Merged
merged 1 commit into from
Apr 5, 2025
Merged

Name typo #656

merged 1 commit into from
Apr 5, 2025

Conversation

Doris26
Copy link
Collaborator

@Doris26 Doris26 commented Apr 5, 2025

Description

Please include a summary of relevant context/issue and your changes.

Tests

https://screenshot.googleplex.com/7cteVpgXZ2pgvbf

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • [ X] I have performed a self-review of my code.
  • [ X] I have necessary comments in my code, particularly in hard-to-understand areas.
  • [X ] I have run one-shot tests and provided workload links above if applicable.
  • [ X] I have made or will make corresponding changes to the doc if needed.

@Doris26 Doris26 force-pushed the fix_typo branch 2 times, most recently from 318fc7e to 69c8c48 Compare April 5, 2025 01:56
wang2yn84
wang2yn84 approved these changes Apr 5, 2025
View reviewed changes
Copy link
Collaborator

@wang2yn84 wang2yn84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So DAG is not triggered because of the wrong id? And it was schedule to run at 8pm?

@richardsliu richardsliu merged commit 2537d3b into master Apr 5, 2025
6 checks passed
@richardsliu richardsliu deleted the fix_typo branch April 5, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wang2yn84 wang2yn84 wang2yn84 approved these changes

@richardsliu richardsliu richardsliu approved these changes

@crankshaw-google crankshaw-google Awaiting requested review from crankshaw-google crankshaw-google is a code owner

@polydier1 polydier1 Awaiting requested review from polydier1 polydier1 is a code owner

@gunjanj007 gunjanj007 Awaiting requested review from gunjanj007 gunjanj007 is a code owner

@stingram stingram Awaiting requested review from stingram stingram is a code owner

@utkarshsharma1 utkarshsharma1 Awaiting requested review from utkarshsharma1 utkarshsharma1 is a code owner

@cneel8986 cneel8986 Awaiting requested review from cneel8986 cneel8986 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Doris26 @wang2yn84 @richardsliu